Knowledge graph UI test by HansRichard · Pull Request #100 · Knox-AAU/UI_React

HansRichard · 2022-12-06T11:09:53Z

No description provided.

Gruppe C test

This reverts commit cc33aea.

KasperHenningsen

Har lige et par kommentare.
I må bare skrive hvis i er uenige 😁

KasperHenningsen · 2022-12-06T11:39:07Z

knox-ui/src/Main_components/KnowledgeGraph.js

+    function Search(id) {
+        document.getElementById('table').innerHTML = "";
+        document.getElementById('svg-body').innerHTML = "";
+
+        const xhr = new XMLHttpRequest();
+        xhr.open('GET', 'http://localhost:3030/SNOMEDTEST?query=PREFIX+skos%3A%3Chttp%3A%2F%2Fwww.w3.org%2F2004%2F02%2Fskos%2Fcore%23%3ESELECT+%3FSUBJECT+%3FPREDICATE+%3FOBJECT+where%7B%0A++%3Chttp%3A%2F%2Fwww.example.org%2F'+id+'%3E+(skos%3A%7C!skos%3A)%7B0%7D+%3FSUBJECT.%0A++%3FSUBJECT+%3FPREDICATE+%3FOBJECT+%0A%7DLIMIT+150%0A', true);
+        xhr.withCredentials = true;
+        xhr.send(null);
+        xhr.onloadend = (event) => {ResponseToTable(xhr.response)};
+
+    }


Kan anbefale at følge 'Service pattern'. der er eksempler på dem i /knox-ui/Services/

KasperHenningsen · 2022-12-06T11:43:18Z

knox-ui/src/Main_components/KnowledgeGraph.js

+        document.getElementById('svg-body').innerHTML = "";
+
+        const xhr = new XMLHttpRequest();
+        xhr.open('GET', 'http://localhost:3030/SNOMEDTEST?query=PREFIX+skos%3A%3Chttp%3A%2F%2Fwww.w3.org%2F2004%2F02%2Fskos%2Fcore%23%3ESELECT+%3FSUBJECT+%3FPREDICATE+%3FOBJECT+where%7B%0A++%3Chttp%3A%2F%2Fwww.example.org%2F'+id+'%3E+(skos%3A%7C!skos%3A)%7B0%7D+%3FSUBJECT.%0A++%3FSUBJECT+%3FPREDICATE+%3FOBJECT+%0A%7DLIMIT+150%0A', true);


I må meget gerne flytte links ud i .env filen, så skal man ikke rette links i koden hvis de en gang skulle ændre sig, eller hvis man vil køre UI'en lokalt.

så kan man lave en '.env.local' når det skal køres localt og en '.env.production' når det skal køres på serveren.

React app er lidt anderledes når man tilføjer env variabler, de skal følge REACT_APP_[ENV_VAR_NAME]
(i kan se på /knox-ui/Services/ hvis det ikke er helt klart)

KasperHenningsen · 2022-12-06T11:48:29Z

knox-ui/src/Main_components/KnowledgeGraph.js

+    function id(){
+      return "kl";
+    }


Der er ingen grund til at bruge 'function' hvis den alligevel altid returnere det samme.

Suggested change

function id(){

return "kl";

}

const id = "kl";

KasperHenningsen · 2022-12-06T11:52:16Z

knox-ui/src/Main_components/KnowledgeGraph.js

+	var force = d3.layout.force().size([1000, 500]);
+
+	var graph = triplesToGraph(svg);
+  console.log(graph);


fjern gerne console.log, det høre ikke til i production.

Suggested change

console.log(graph);

KasperHenningsen · 2022-12-06T11:55:11Z

knox-ui/src/Main_components/KnowledgeGraph.js

+        //linkTexts.append("title")
+        //		.text(function(d) { return d.predicate; });


Hvis dette ikke skal bruges må i gerne fjerne det.

Suggested change

//linkTexts.append("title")

// .text(function(d) { return d.predicate; });

KasperHenningsen · 2022-12-06T12:01:09Z

knox-ui/src/Main_components/KnowledgeGraph.js

+                  .call(force.drag)
+              ;//nodes		


#100 (comment)

Suggested change

.call(force.drag)

;//nodes

.call(force.drag);

KasperHenningsen · 2022-12-06T12:03:16Z

knox-ui/src/Main_components/KnowledgeGraph.js

+              .text( function (d) { return d.label; })
+            ;


I har mange "floating" semikoloner.

Suggested change

.text( function (d) { return d.label; })

;

.text( function (d) { return d.label; });

KasperHenningsen · 2022-12-06T12:03:52Z

knox-ui/src/Main_components/KnowledgeGraph.js

+          .attr("y", function(d) { return d.y + 3; })
+
+
+          ;


#100 (comment)

Suggested change

.attr("y", function(d) { return d.y + 3; })

;

.attr("y", function(d) { return d.y + 3; });

KasperHenningsen · 2022-12-06T12:04:09Z

knox-ui/src/Main_components/KnowledgeGraph.js

+          .attr("y", function(d) { return 4 + (d.s.y + d.p.y + d.o.y)/3 ; })
+
+          ;


#100 (comment)

Suggested change

.attr("y", function(d) { return 4 + (d.s.y + d.p.y + d.o.y)/3 ; })

;

.attr("y", function(d) { return 4 + (d.s.y + d.p.y + d.o.y)/3 ; });

KasperHenningsen · 2022-12-06T12:04:29Z

knox-ui/src/Main_components/KnowledgeGraph.js

+        .start()
+        ;


#100 (comment)

Suggested change

.start()

;

.start();

selectionator · 2022-12-06T12:14:27Z

knox-ui/src/Main_components/KnowledgeGraph.js

+        ;
+
+    }
+    function hej(){


Hej 😄
Den burde have et andet navn før den bliver skubbet op 😄

selectionator

Er enig i de ting Kasper også har sat kommentarer ved. Tænker at det kunne være dejligt at sørge for at koden er ryddet op inden den skubbes op på branchen 😊

HansRichard added 3 commits December 6, 2022 11:17

KnowledgeGraph

dac0c50

Gruppe C test

sådan

cc33aea

Revert "sådan"

6695e9d

This reverts commit cc33aea.

RuneAagaard previously approved these changes Dec 6, 2022

View reviewed changes

KasperHenningsen requested changes Dec 6, 2022

View reviewed changes

selectionator reviewed Dec 6, 2022

View reviewed changes

selectionator requested changes Dec 6, 2022

View reviewed changes

update to get labels

303bea2

HansRichard dismissed RuneAagaard’s stale review via 303bea2 December 13, 2022 08:25

HansRichard added 3 commits December 13, 2022 12:50

Max triples generated update

4c0eecc

Fix af prompt

e436566

opdatering

e865901

		//linkTexts.append("title")
		// .text(function(d) { return d.predicate; });

	.text( function (d) { return d.label; })
	;
	.text( function (d) { return d.label; });

		.attr("y", function(d) { return 4 + (d.s.y + d.p.y + d.o.y)/3 ; })

		;

Comments

Conversation

HansRichard commented Dec 6, 2022

Uh oh!

KasperHenningsen left a comment

Choose a reason for hiding this comment

Uh oh!

KasperHenningsen Dec 6, 2022

Choose a reason for hiding this comment

Uh oh!

KasperHenningsen Dec 6, 2022

Choose a reason for hiding this comment

Uh oh!

KasperHenningsen Dec 6, 2022

Choose a reason for hiding this comment

Uh oh!

KasperHenningsen Dec 6, 2022

Choose a reason for hiding this comment

Uh oh!

KasperHenningsen Dec 6, 2022

Choose a reason for hiding this comment

Uh oh!

KasperHenningsen Dec 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KasperHenningsen Dec 6, 2022

Choose a reason for hiding this comment

Uh oh!

KasperHenningsen Dec 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KasperHenningsen Dec 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KasperHenningsen Dec 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

selectionator Dec 6, 2022

Choose a reason for hiding this comment

Uh oh!

selectionator left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

KasperHenningsen Dec 6, 2022 •

edited

Loading

KasperHenningsen Dec 6, 2022 •

edited

Loading

KasperHenningsen Dec 6, 2022 •

edited

Loading

KasperHenningsen Dec 6, 2022 •

edited

Loading