refactor: move enterprise apis to insomnia-api #9552
+81
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors enterprise-related API functions by moving them from the insomnia package to the insomnia-api package, improving code organization and separation of concerns.
- Extracts four enterprise API endpoints into a dedicated
enterprise.tsmodule in theinsomnia-apipackage - Updates
resource.usage.tsxto import and use the centralized API functions - Removes local API implementations and TypeScript interfaces in favor of the shared module
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/insomnia-api/src/enterprise.ts | New file containing four enterprise API functions (getResourceUsage, getOwnEnterprises, getAccountUsedSeats, getEnterpriseLicenseUsage) with their TypeScript interfaces |
| packages/insomnia-api/src/index.ts | Adds export statement for the new enterprise module |
| packages/insomnia/src/routes/resource.usage.tsx | Removes local API implementations and updates imports to use the centralized insomnia-api functions; updates function calls to use new parameter object syntax |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+24
to
+28
| interface EnterpriseOwner { | ||
| id: string; | ||
| name: string; | ||
| role: string; | ||
| } |
There was a problem hiding this comment.
Consider exporting the TypeScript interfaces to improve API usability and type safety. While the current implementation allows TypeScript to infer return types, explicitly exporting these interfaces (ResourceUsage, EnterpriseOwner, AccountUsedSeats, LicenseUsage) would allow consumers to reference these types directly if needed, similar to how CurrentPlan, UserProfile, and RemoteFile are exported in user.ts. This provides better type documentation and enables consumers to type-check data structures independently of the API functions.
Comment on lines
+39
to
+44
| interface AccountUsedSeats { | ||
| memberCount: number; | ||
| inviteCount: number; | ||
| used: number; | ||
| total: number; | ||
| } |
There was a problem hiding this comment.
Consider exporting the TypeScript interfaces to improve API usability and type safety. While the current implementation allows TypeScript to infer return types, explicitly exporting these interfaces (ResourceUsage, EnterpriseOwner, AccountUsedSeats, LicenseUsage) would allow consumers to reference these types directly if needed, similar to how CurrentPlan, UserProfile, and RemoteFile are exported in user.ts. This provides better type documentation and enables consumers to type-check data structures independently of the API functions.
Comment on lines
+55
to
+61
| interface LicenseUsage { | ||
| used: number; | ||
| total: number; | ||
| memberCount: number; | ||
| inviteCount: number; | ||
| free: number; | ||
| } |
There was a problem hiding this comment.
Consider exporting the TypeScript interfaces to improve API usability and type safety. While the current implementation allows TypeScript to infer return types, explicitly exporting these interfaces (ResourceUsage, EnterpriseOwner, AccountUsedSeats, LicenseUsage) would allow consumers to reference these types directly if needed, similar to how CurrentPlan, UserProfile, and RemoteFile are exported in user.ts. This provides better type documentation and enables consumers to type-check data structures independently of the API functions.
Comment on lines
+4
to
+13
| interface ResourceUsage { | ||
| mocks: { | ||
| quota: number; | ||
| calls: number; | ||
| autoPurchase: { | ||
| enabled: boolean; | ||
| unit: number; | ||
| }; | ||
| }; | ||
| } |
There was a problem hiding this comment.
Consider exporting the TypeScript interfaces to improve API usability and type safety. While the current implementation allows TypeScript to infer return types, explicitly exporting these interfaces (ResourceUsage, EnterpriseOwner, AccountUsedSeats, LicenseUsage) would allow consumers to reference these types directly if needed, similar to how CurrentPlan, UserProfile, and RemoteFile are exported in user.ts. This provides better type documentation and enables consumers to type-check data structures independently of the API functions.
✅ Circular References ReportGenerated at: 2026-01-09T08:10:19.622Z Summary
Click to view all circular references in PR (167)Click to view all circular references in base branch (167)Analysis✅ No Change: This PR does not introduce or remove any circular references. This report was generated automatically by comparing against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
INS-1878
Move enterprise related apis to insomnia-api
Changes