Kount_Ris_Request::getResponse to throw exception if error in the API request#22
Open
tisogawa wants to merge 2 commits intoKount:masterfrom
Open
Kount_Ris_Request::getResponse to throw exception if error in the API request#22tisogawa wants to merge 2 commits intoKount:masterfrom
tisogawa wants to merge 2 commits intoKount:masterfrom
Conversation
# Conflicts: # src/Kount/Ris/Request.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is an error in the API request, the
Kount_Ris_Request::getResponse()function doesn't surface it. The function returns a normalKount_Ris_Responseobject instead as if the request was successful. However, the returned object consists of empty or invalid data so it cannot be used for further data processing. The function should raise an appropriate error in this case. Otherwise, the users of the SDK need to check the validity of the returned object by themselves before proceeding.In this PR, I changed the
Kount_Ris_Request::getResponse()function to throwKount_Ris_Exception(which has no use as of now) on a cURL error or on the HTTP status code >= 400.