Open
Conversation
- In processENSEvent function if order does not exist order.custom.kount_ENSF = true will trigger an Exception which will not be handled by try/catch block. Added null check condition - Added siteID to the logs for better understanding which order (from which Site) triggered it - renamed e in catch to error since e already used in the upper try/catch block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had cases in Production when error handling did not work correctly because of possible Exception error.
Changes
processENSEventfunction if order does not existorder.custom.kount_ENSF = truewill trigger an Exception which will not be handled by try/catch block and the Job will fail without any useful logs about the reason. Added null check condition to cover this caseein catch toerrorsinceealready used in the upper try/catch block and it creates collisionThis fix applied and tested in the real project in Production