Made channel configurable using existing custom preference#8
Open
okater wants to merge 1 commit intoKount:masterfrom
Open
Made channel configurable using existing custom preference#8okater wants to merge 1 commit intoKount:masterfrom
okater wants to merge 1 commit intoKount:masterfrom
Conversation
This resolves an issue with hardcoding channel by Site ID which is the same across different instances (DEV/STG/PRD) Used existing channel preference from legacy kount integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves an issue with hardcoding channel by Site ID which is the same across different instances (Sandboxes/DEV/STG/PRD)
As a result, previously placed orders from different instances went to same channel in Kount which makes QA troublesome.
Used existing channel preference from legacy Kount integration