Skip to content

Config for the new magic glass#374

Open
AcousticJamm-dev wants to merge 5 commits intoKristalTeam:mainfrom
AcousticJamm-dev:new-magic-glass
Open

Config for the new magic glass#374
AcousticJamm-dev wants to merge 5 commits intoKristalTeam:mainfrom
AcousticJamm-dev:new-magic-glass

Conversation

@AcousticJamm-dev
Copy link
Contributor

I just feel like the new magic glass sprite should be used if it's in the engine. Let me know if any of the chapters' configs is wrong.

I just feel like the new magic glass sprite should be used if it's in the engine. Let me know if any of the chapters' configs is wrong.
@MrOinky
Copy link
Contributor

MrOinky commented Jun 24, 2025

Chapter 3 uses the old spr_magicalGlass_classic sprite in DELTARUNE, so only Chapter 4 should use the new one
As for the config name it might make more sense to be oldMagicGlass with the condition inverted for consistency with the names of other visual changes in the config?

@AcousticJamm-dev
Copy link
Contributor Author

Got it, will make the change

@AcousticJamm-dev
Copy link
Contributor Author

Both suggested changes have been made.

@nightpool
Copy link
Contributor

@AcousticJammYT I noticed that you're using tabs instead of spaces here. You can see in the Github web UI that this is leading to mismatched indentation / whitespace errors. I'm not sure what the maintainers' opinion is, but I would suggest updating the formatting and whitespace style to match the rest of the file:

image

Which editor did you use to edit this file? VSCode will read the .editorconfig file at the root of this repository and configure your tab/space settings automatically, among other formatting options.

@AcousticJamm-dev
Copy link
Contributor Author

I hate how Github doesn't automatically convert them. And I'm actually using N++.

In any case, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants