Improve modRequire with caching and library support#528
Open
Hyperboid wants to merge 5 commits intoKristalTeam:mainfrom
Open
Improve modRequire with caching and library support#528Hyperboid wants to merge 5 commits intoKristalTeam:mainfrom
Hyperboid wants to merge 5 commits intoKristalTeam:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry if I didn't do a good job explaining this, it's 5AM Again
Basically the caching is like
package.loaded, andmodRequire("libraries.mylib.thing")is the same aslibRequire("mylib", "thing")but actually with some degree language server support (of course LS will get confused if lib folder name differs from ID)Motivation: I'm tired of creating and maintaining
globals.luafiles to trick the language server