Gh 663 #666
Draft
Gh 663 #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When group is set on the operator runtime, the group is passed into the txt that is inside provide for every DNSRecord managed by the operator. Signed-off-by: Jim Fitzpatrick <jfitzpat@redhat.com>
Signed-off-by: Michael Nairn <mnairn@redhat.com>
Updates the local DNSRecord accessor to add the group label to all endpoints if one is set in the record status. * Add `GetGroup()` to `DNSRecordAccessor` interface * Add group to logger * Set status group in local record reconcile ToDo: * Fix health check adapter, need to manipulate record.spec.endpoints for the chain to work correctly * Fix update of group, premature reconcile check currently prevents it from updating correctly on update. * Add targets to labels * Add tests Signed-off-by: Michael Nairn <mnairn@redhat.com>
Signed-off-by: Michael Nairn <mnairn@redhat.com>
Move removeUnhealthyEndpoints call to `getEndpoints()` to get round an issue where the spec endpoints are being incorrectly modified and saved to the spec when saving the provider labels. Follow on task required to fix this since we can't really have the spec being saved incorrectly in any situation. Signed-off-by: Michael Nairn <mnairn@redhat.com>
Adapt the behaviour of Registry.AdjustEndpoints instead of DNSRecordAccessor.GetEndpoints(). Labelling appears to work better after endpoints have been adjusted so will try it this way instead. Signed-off-by: Michael Nairn <mnairn@redhat.com>
Signed-off-by: Phil Brookes <pbrookes@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Phil Brookes <pbrookes@redhat.com> Signed-off-by: Phil Brookes <pbrookes@redhat.com> Signed-off-by: Phil Brookes <pbrookes@redhat.com> Signed-off-by: Phil Brookes <pbrookes@redhat.com> Signed-off-by: Phil Brookes <pbrookes@redhat.com> Signed-off-by: Phil Brookes <pbrookes@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Maskym Vavilov <mvavilov@redhat.com>
philbrookes
requested changes
Dec 4, 2025
Contributor
philbrookes
left a comment
philbrookes
left a comment
There was a problem hiding this comment.
It'd be easier to read this if you opened the PR against my branch for now, until it merges.
2 small changes, plus the failing CI needs addressing (unless that's due to my branch?)
| registryHost, hostExists := registryMap.Hosts[strings.Replace(ep.DNSName, "*", internal.TXTRegistryWildcardReplacement, 1)] | ||
| if hostExists { | ||
| // check if we have deleting group associated with this host | ||
| _, groupExists := registryHost.Groups[types.Group(groupName)] |
Contributor
There was a problem hiding this comment.
Suggested change
| _, groupExists := registryHost.Groups[types.Group(groupName)] | |
| if _, groupExists := registryHost.Groups[types.Group(groupName)]; groupExists { | |
| affectedEndpoints = append(affectedEndpoints, ep) | |
| } |
| TXTRecordGroupKey = "groups" | ||
|
|
||
| GroupRecordTTL = 60 | ||
| GroupRecordTTL = 15 |
Contributor
There was a problem hiding this comment.
better not to commit this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.