[don't pull]add deployer with enhancedStepsReserve#1050
Draft
ducquangkstn wants to merge 1 commit intomasterfrom
Draft
[don't pull]add deployer with enhancedStepsReserve#1050ducquangkstn wants to merge 1 commit intomasterfrom
ducquangkstn wants to merge 1 commit intomasterfrom
Conversation
ducquangkstn
force-pushed
the
addEnhancedOpenData-deployment
branch
from
6d3689f to
9f9b604
Compare
ilanDoron
reviewed
Aug 2, 2020
Contributor
ilanDoron
left a comment
ilanDoron
left a comment
There was a problem hiding this comment.
nice
the deploy script is short and elegant.
always nice to have shorter code.
is nonce handled automatically?
|
|
||
| async function main() { | ||
| const accounts = await web3.eth.getAccounts(); | ||
| deployer = accounts[0]; |
Contributor
There was a problem hiding this comment.
plan is to send funds to this address?
if so how to return back remaining funds when done?
have private key?
consider saving it locally.
Contributor
Author
There was a problem hiding this comment.
if you set the network is ropsten in the script, accounts[0] will be the address from the privatekey in .env file
| .catch(error => { | ||
| console.error(error); | ||
| process.exit(1); | ||
| }); No newline at end of file |
| deployer = accounts[0]; | ||
| console.log(`deployer address at ${deployer}`); | ||
|
|
||
| gasPrice = new BN(75).mul(new BN(10).pow(new BN(9))) |
Contributor
There was a problem hiding this comment.
maybe use yargs for gas price?
Contributor
Author
There was a problem hiding this comment.
if we run the script with buidler, we can not read value from args
but we can read the value from environment variable
ducquangkstn
force-pushed
the
addEnhancedOpenData-deployment
branch
from
9f9b604 to
1fd44a3
Compare
ducquangkstn
force-pushed
the
addEnhancedOpenData-deployment
branch
3 times, most recently
from
1712d1d to
9006655
Compare
ducquangkstn
force-pushed
the
addEnhancedOpenData-deployment
branch
from
9006655 to
454fb4a
Compare
ducquangkstn
force-pushed
the
addEnhancedOpenData-deployment
branch
from
454fb4a to
292ca30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.