Conversation
ductm54
force-pushed
the
duc/report_github_comment
branch
from
f85ae8c to
e42e3a0
Compare
ductm54
force-pushed
the
duc/report_github_comment
branch
from
e42e3a0 to
535bf55
Compare
ilanDoron
reviewed
Sep 6, 2020
Contributor
ilanDoron
left a comment
ilanDoron
left a comment
There was a problem hiding this comment.
Please in next meeting share design of the reports.
what output should I expect from all the changes?
or is this only infrastructure for the reports
My thoughts for report design are
A report system that can be easily duplicated to all other SC repositories we opened.
the reports should compare the changes in the PR to master in each repo.
unless explicitly changed to another branch.
the report should, per PR:
- comment won the PR with gas changes- using per repo the local gas report file.
- comment file size changes compared to master.
| var client = github.client(process.env.GITHUB_TOKEN); | ||
|
|
||
| async function getBotInfo() { | ||
| let ghme = client.me(); |
Contributor
There was a problem hiding this comment.
I don't understand the name.
what is ghme?
| return result[0]; | ||
| } | ||
|
|
||
| var ghpr = client.issue(process.env.TRAVIS_REPO_SLUG, process.env.TRAVIS_PULL_REQUEST); |
Contributor
There was a problem hiding this comment.
please use let.
and I don'lt understand the name again.
what gh stands for?
what is ghpr?
Pr is for pull request?
| "ethers": "5.0.4", | ||
| "ganache-cli": "6.8.2", | ||
| "mathjs": "4.4.2", | ||
| "octonode": "^0.9.5", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.