Perf/optimize transmon calculations #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add @lru_cache decorator for E01 and anharmonicity calculations - Cache key is rounded (EJ, EC) tuple to increase hit rate - Each parallel worker builds its own cache for repeated calculations - Reduces HWC test time from ~6min to ~72sec Benchmark: 16.5M row dataset - Before: ~360 seconds - After: ~72 seconds - Speedup: ~5x
The lru_cache is per-process, so when using joblib Parallel, the main process shows 0 hits/misses. Added guard for this case.
Key optimizations: - Pre-compute unique EC values in main process before parallelization - Use numpy searchsorted for O(log n) value mapping instead of O(n) loop - Vectorized EC calculation with numba - LRU cache for transmon E01/anharmonicity calculations - Separate g-only parallel processing after pre-computation Benchmark (16.5M row half-wave cavity dataset): - Before: ~6 minutes (360 seconds) - After: ~51 seconds for H params calculation - Total test: ~2:11 (includes 3x find_closest calls) - Speedup: ~7x for Hamiltonian parameter calculation Also: - Updated release notes for v0.4.0 with performance improvements - Fixed duplicate print statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.