add naga mainnet #1033
Open
add naga mainnet #1033
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the Naga mainnet network could not be used with the Lit client. The issue occurred because NagaMainnetModule was not included in the NagaNetworkModule union type, causing the network parameter to be undefined when passed to createLitClient, which resulted in a TypeError: Cannot read properties of undefined (reading 'id') error at runtime.
Key changes:
- Added
NagaMainnetModuleimport from@lit-protocol/networks - Added
NagaMainnetModuleto theNagaNetworkModuleunion type - Refactored imports to use grouped import syntax for better readability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
naga prod is up! adam tried to use it, and found that it doesn't work due to this bug. The actual error is
TypeError: Cannot read properties of undefined (reading 'id')from this linejs-sdk/packages/lit-client/src/lib/LitClient/createLitClient.ts
Line 110 in 35d3016
USAGE
Local Env Setup