Skip to content

Collection of multiple smaller issues #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
dominikgeissler wants to merge 50 commits into
base: main
Choose a base branch
from
Draft

Collection of multiple smaller issues #62

dominikgeissler wants to merge 50 commits into from

Conversation

@dominikgeissler
Copy link
Collaborator

@dominikgeissler dominikgeissler commented Mar 6, 2025 •
edited
Loading

dominikgeissler and others added 30 commits January 2, 2025 13:28
@dominikgeissler
refactored example structure
aa6a0db
@dominikgeissler
adjusted benchmark script to execute files with provided commands
138c61f
@dominikgeissler
changed variable name
68b13eb
@dominikgeissler
add comment
6819f24
@dominikgeissler
Runtime comparison only if more than 1 engine is selected
74b3c6d
@dominikgeissler
more precise help text
ec7e572
fixed independent vars call
ae8b07f
added first loop-free equiv example
2e34b21
@dominikgeissler
Runtime comparison only if more than 1 engine is selected
f2dbd22
@dominikgeissler
more precise help text
d3a73f0
@dominikgeissler
fixed independent vars call
0f0d367
@dominikgeissler
added first loop-free equiv example
f6c0aea
@dominikgeissler
moved cov_phi, added check for variable difference
df17cdd
refactored equiv check
b7fbec0
deleted
19640c1
fixed
4878983
minor
28f0bfb
minor
fb40b98
@dominikgeissler
small example
1e077df
@dominikgeissler
small example
e69fc2a
@dominikgeissler
added mockup test for new equality check
7b1eb64
fixed broken equivalence tests
b0bb58d
name change
59b4de0
optional type
63c23ca
@dominikgeissler
added automatic benchmark tests & doc regarding file structure + nami…
41df41e 
…ng convention
@dominikgeissler
benchmark script should now be able to handle interactive programs
81a390a
@LKlinke
Merge pull request #57 from LKlinke/feature/54/equality-checks
b1902c5 
Equality checks for two loop free programs
@dominikgeissler
remove duplicate
4f5c926
@dominikgeissler @LKlinke
removed duplicates from solutions
de7383a
@dominikgeissler @LKlinke
todos in examples
48e274e
@dominikgeissler dominikgeissler marked this pull request as ready for review March 6, 2025 14:14
@dominikgeissler dominikgeissler changed the title Collection of multiple smaller issues Draft: Collection of multiple smaller issues Mar 6, 2025
@dominikgeissler dominikgeissler marked this pull request as draft March 6, 2025 14:24
@dominikgeissler dominikgeissler marked this pull request as ready for review March 9, 2025 13:30
@dominikgeissler dominikgeissler changed the title Draft: Collection of multiple smaller issues Collection of multiple smaller issues Mar 9, 2025
LKlinke
LKlinke reviewed Mar 10, 2025
View reviewed changes
LKlinke
LKlinke reviewed Mar 10, 2025
View reviewed changes
pgfexamples/inference/loopy/skip_random_walk.pgcl
Copy link
Owner

@LKlinke LKlinke Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we get issues?

Copy link
Collaborator Author

@dominikgeissler dominikgeissler Mar 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont know, this comment was there before I started working here, but I will try it out

Copy link
Collaborator Author

@dominikgeissler dominikgeissler Mar 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I executed it with the following command

python prodigy/cli.py --engine ginac main pgfexamples/inference/loopy/skip_random_walk.pgcl

followed by a fixed iteration and it worked fine, im not sure if and where an issue exists

LKlinke
LKlinke reviewed Mar 10, 2025
View reviewed changes
LKlinke
LKlinke reviewed Mar 10, 2025
View reviewed changes
LKlinke
LKlinke reviewed Mar 10, 2025
View reviewed changes
LKlinke
LKlinke reviewed Mar 10, 2025
View reviewed changes
pyproject.toml
jinja2 = "3.1.4"
rope = "^0.17.0"
pytest-cov = "^2.9.0"
pytest-ordering = "^0.6"
Copy link
Owner

@LKlinke LKlinke Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be necessary. We must investigate the issue related to this.

LKlinke
LKlinke reviewed Mar 10, 2025
View reviewed changes
LKlinke
LKlinke reviewed Mar 10, 2025
View reviewed changes
LKlinke
LKlinke reviewed Mar 10, 2025
View reviewed changes
LKlinke
LKlinke requested changes Mar 10, 2025
View reviewed changes
Copy link
Owner

@LKlinke LKlinke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see individual comments.

@dominikgeissler dominikgeissler marked this pull request as draft March 10, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LKlinke LKlinke LKlinke requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

compile_pgcl doesnt like boolean type variables Christmas issues

3 participants

@dominikgeissler @LKlinke