Made player help command configurable #265
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LMBishop
requested changes
Sep 10, 2021
| Set<String> permissions = plugin.getConfig().getConfigurationSection("command.player-help").getKeys(false); | ||
| for (String permission : permissions) { | ||
| if(!permission.contains("default") && !sender.hasPermission(subcommands.get(permission).getPermission())) continue; | ||
| for(String message : plugin.getConfig().getStringList("command.player-help."+permission)) { |
Owner
There was a problem hiding this comment.
Please don't use a string list to define multiline messages, instead use on of the many different ways to define newlines in YAML
| # Trying to add new categories? This has been moved to categories.yml | ||
|
|
||
| #Default section doesn't require any permission | ||
| command: |
Owner
There was a problem hiding this comment.
This should be with the other messages (though this system is going to redone at some point in the future anyway)
3 tasks
2 tasks
|
Any updates? 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made it so the player help can be translated, doesnt do the admin and other parts.