More proper bow item detection #833
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krakenied
force-pushed
the
fix/proper-bow-enchants-tracking
branch
2 times, most recently
from
143b9c2 to
184ce28
Compare
Introduces Projectile2ItemCache to reliably associate fired projectiles with the item used to shoot them. This replaces the previous temporary workaround that was vulnerable to player exploits, ensuring accurate item tracking during damage events.
Krakenied
force-pushed
the
fix/proper-bow-enchants-tracking
branch
from
184ce28 to
8368456
Compare
Krakenied
commented
Dec 18, 2025
| final Projectile projectile = event.getProjectile(); | ||
| final ItemStack item = event.getItemStack(); | ||
|
|
||
| Projectile2ItemCache.this.backingMap.put(projectile, item); |
Collaborator
Author
There was a problem hiding this comment.
For some reason, doesn't really work for tridents - event is called, however the projectile reference from damage event differs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces Projectile2ItemCache to reliably associate fired projectiles with the item used to shoot them. This replaces the previous temporary workaround that was vulnerable to player exploits, ensuring accurate item tracking during damage events.