Skip to content

Conversation

@vish-mv
Copy link

@vish-mv vish-mv commented Sep 12, 2024

Purpose

Migrate gig client deployment from currently deployed azure to Choreo

Changes Made

  • Update the alpine version because Choreo doesn't support existing version
  • Update npm install to legacy peer deeps because there can be conflicts in the installation =with version changes
  • Update the server URL to Choreo deployed URL
  • Removed public react app URL
  • Added a non root user to the docker
  • Added new paths for the nginx config and set permission access to those path in the Dockerfile

Dockerfile Outdated

# set baseurl to get connected with backend API
ARG SERVER_URL=http://localhost:9000/
ARG SERVER_URL=https://f2c7f522-ef47-48ce-a429-3fc2f15d2011-copilote1.e1-us-east-azure.choreoapis.dev/ldf/gig-backend/v1.0/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this URL fixed before merging this PR

# Switch to the non-root user
USER 10014

EXPOSE 8080

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's confirm the port that support scale to zero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants