Open
Conversation
Collaborator
|
@mfisherlevine is unavailable this week so the delay to update in Spectractor DM version will be too long for your use case. However, you can clone the DESC Spectractor at USDF, switch to this branch, and edit your |
Collaborator
|
Just to say that I'm back now, and free to do the update to the new faster version any time this week. This update should be pretty quick and easy I think. |
Collaborator
|
Before merging: needs to add the holo4_001 transmission and ratio 2/1 measurements from optical test bench (at the moment they are just a copy holo4_003). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have just copied all the disperser holo4_003 files into holo4_001 and added the corresponding new configuration in setup.py
I have tested in a stanalone version that Spectractor was able to recognize a fits file having the tag holo4_001
Nothing more.
I am checking this version at usdf now. I suppose when the modifications will be put in master, the new stuff will be available in Spectractor DM version ?
What is the speed of this update in DM ? (will it comes after w_2023_35 ?)