Skip to content

Comments

StarDICE #148

Open
jeremyneveu wants to merge 42 commits intomasterfrom
stardice
Open

StarDICE #148
jeremyneveu wants to merge 42 commits intomasterfrom
stardice

Conversation

@jeremyneveu
Copy link
Collaborator

@jeremyneveu jeremyneveu commented Dec 23, 2023

Check differences between stardice and master branches

tsouverin and others added 22 commits September 15, 2023 16:02
@tsouverin
change extension of the source file from xyls to axy
ae44ddc
@jeremyneveu
Merge branch 'stardice' of https://github.com/LSSTDESC/Spectractor in…
e189098 
…to stardice
@tsouverin
add few lines to do the astrometry with the data with masked spectrums
2b95133
@tsouverin
change extension from .xyls to .axy
f812658
@tsouverin
"deal with data with spectrums masked"
9d74ab6
@tsouverin
Merge branch 'stardice' of github.com:LSSTDESC/Spectractor into stardice
69b55cb
@tsouverin
small change of syntax
a5ccff5
@tsouverin
add w in returns of SpectractorRun
e2ace08
@jeremyneveu
Merge branch 'v3.0.3' of https://github.com/LSSTDESC/Spectractor into…
13aa26f 
… stardice
@jeremyneveu
Merge pull request #146 from LSSTDESC/v3.0.3
2ffe6d3 
V3.0.3 for stardice
@jeremyneveu
optimal Ndof with weighted FWHM mean
1f116ae
@jeremyneveu
add image.target_label in load_STARDICE
e451b79
@jeremyneveu
SPECTRACTOR_DECONVOLUTION_PSF2D = False -> True
ab11026 
SPECTRACTOR_DECONVOLUTION_FFM = False -> True
PSF_POLY_ORDER = 2 -> 4
PSF_PIXEL_STEP_TRANSVERSE_FIT = 10 -> 1
@jeremyneveu
Merge branch 'stardice' of https://github.com/LSSTDESC/Spectractor in…
e830e27 
…to stardice
@jeremyneveu
SPECTRACTOR_ATMOSPHERE_SIM = getobsatmo
851a7dd
@jeremyneveu
OBS_NAME = STARDICE -> OHP
a15f1fa 
for getobsatmo
@jeremyneveu
OBS_NAME = STARDICE -> OHP
4a8723a 
for getobsatmo
@jeremyneveu
don't use apply_max_width_to_bounds otherwise y_c params have boundar…
6fbfa78 
…ies (0, 2Ny) in FFM and spectrogramfit when using from_poly_to_profile_params functions : problem if y_c is negative
@jeremyneveu
evaluate PSF FWHM centering the PSF on the pixel grid
0b102a3
@jeremyneveu
cleaning
ae0a9f4
@jeremyneveu
add shift_x
ce84ed5
@jeremyneveu
typo
c85d82f
@coveralls
Copy link

coveralls commented Dec 23, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7613481679

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.1%) to 89.88%
Totals Coverage Status
Change from base Build 7275666541: 2.1%
Covered Lines: 7238
Relevant Lines: 8053
💛 - Coveralls

Thierry Souverin and others added 8 commits November 6, 2025 19:33
add logic to analyze the white lamp from monodice
0e27ca8
Merge branch 'stardice' of github.com:LSSTDESC/Spectractor into stardice
ca00daf
@jeremyneveu
for target centroid fitting strategy GUESS, don't fit the position in…
aca0fcd 
… the rotated image and trust rotation
@jeremyneveu
Merge branch 'stardice' of https://github.com/LSSTDESC/Spectractor in…
20c4b97 
…to stardice
@jeremyneveu
for target centroid fitting strategy WCS, don't fit the position in t…
ed0e41a 
…he rotated image and trust rotation
@tsouverin
Solve bugs and first steps to perform multispectra exrtaction (target…
903cd19 
…_lable suffix, handle spectra near the detector edges)
@tsouverin
Merge branch 'stardice' of github.com:LSSTDESC/Spectractor into stardice
73fcd5a
handle atmospheric fit when wls for simulation and spectrum extractio…
399b7fe 
…n are different (happens when part of the spectrum lands out of detector)
jeremyneveu
jeremyneveu commented Dec 18, 2025
View reviewed changes
config/stardice.ini Outdated
=======
OBS_NAME = OHP
#STARDICE
>>>>>>> Stashed changes
Copy link
Collaborator Author

@jeremyneveu jeremyneveu Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh you committed merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeremyneveu @coveralls @tsouverin