Open
Conversation
zZeck
commented
Apr 17, 2021
| while (count--) { | ||
| /* extract the x/y coordinates */ | ||
| coord = ((frac >> (32-7)) | ((frac >> (32-23)) << 7)) & 16383; | ||
| coord = ((yfrac >> 24) & 0b00000001111111) | (( xfrac >> 17) & 0b11111110000000); |
Author
There was a problem hiding this comment.
Binary constants are not standard C, but it makes the code easier to understand. I can change this if needed.
|
I can confirm this PR works as expected:
|
Author
|
In hindsight, I should have made the comparison images on a level with straight lines in the floor texture. Thanks for vouching for the PR. Planning on doing anything else in ROTT? |
I don't have much in mind right now, but maybe I'll contribute QOL improvements in the future 🙂 |
Calinou
approved these changes
Nov 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code has insufficient precision in the xstep and ystep used for floor/ceiling. This lack of precision results in very visible error accumulating as DrawRow renders left to right. Look at the distortion on the right side in the original.
Original
Improved
Credit to a 2019 Kaiser tweet for pointing out the problem.
It would be nice if #42 went in ahead of this. I did a hackier work around the same mingw-w64 problem for w_wad.c.