Skip to content

Conversation

@labkey-jeckels
Copy link
Contributor

Rationale

The crawler found a place where we return a 500 error for bad IDs on the URL

ERROR ExceptionUtil            2025-03-02T19:49:29,387    http-nio-8111-exec-10 : Unhandled exception: For input string: "">'>'"</script><img src="x" onerror="alert('8(')">"
java.lang.NumberFormatException: For input string: "">'>'"</script><img src="x" onerror="alert('8(')">"
	at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67) ~[?:?]
	at java.base/java.lang.Integer.parseInt(Integer.java:654) ~[?:?]
	at java.base/java.lang.Integer.parseInt(Integer.java:786) ~[?:?]
	at org.scharp.atlas.pepdb.PepDBController$DisplayPeptideGroupInformationAction.getView(PepDBController.java:445) ~[pepdb-25.3-SNAPSHOT.jar:?]
	at org.scharp.atlas.pepdb.PepDBController$DisplayPeptideGroupInformationAction.getView(PepDBController.java:438) ~[pepdb-25.3-SNAPSHOT.jar:?]
	at org.labkey.api.action.SimpleViewAction.handleRequest(SimpleViewAction.java:75) ~[api-25.3-SNAPSHOT.jar:?]

Changes

  • Switch to a NotFoundException

Copy link
Member

@labkey-tchad labkey-tchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a minor change to this action's behavior (blocking cross-folder peptide references) but I presume that is intended.

@labkey-jeckels labkey-jeckels merged commit f923709 into release25.3-SNAPSHOT Mar 3, 2025
3 checks passed
@labkey-jeckels labkey-jeckels deleted the 25.3_fb_pepDbCrawlerFailure branch March 3, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants