Issue 53153: Accept rowId value for "AliquotedFrom"#1815
Closed
labkey-nicka wants to merge 2 commits intodevelopfrom
Closed
Issue 53153: Accept rowId value for "AliquotedFrom"#1815labkey-nicka wants to merge 2 commits intodevelopfrom
labkey-nicka wants to merge 2 commits intodevelopfrom
Conversation
labkey-susanh
approved these changes
Jun 24, 2025
Contributor
Author
|
Taking a different approach. See #1824. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This addresses Issue 53153 by updating the server-side to accept sample rowIds as the value for the
AliquotedFromfield. Formerly, it would only accept the name of a sample due to limitations around name expression parsing. However, our applications, and the query metadata for theAliquotedFromcolumn annotate the value of the column to be the rowId -- not the name. This results in difficult behaviors where we always need to resolve the name of sample even if we have the rowId.Related Pull Requests
Changes