Merged
Conversation
This was referenced Jul 10, 2025
cnathe
approved these changes
Jul 11, 2025
- remove circular-dependency-plugin
labkey-nicka
force-pushed
the
fb_nodejs_22
branch
from
3250237 to
16e0299
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Package updates for
@labkey/build,@labkey/test,@labkey/componentsand@labkey/eslint-config. These package updates are aligned with NodeJS v22 which we're updating as a part of these changes.Related Pull Requests
Changes
@labkey/build
circular-dependency-pluginas it causes deprecation warnings in builds, is no longer maintained (since 2021) and does not recognize circular dependencies that ESLint recognizes. Moving forward we'll work with ESLint to help find these.@labkey/components
@labkey/eslint-config
@labkey/test