Conversation
# Conflicts: # biologics/package-lock.json # biologics/package.json # inventory/package-lock.json # inventory/package.json # sampleManagement/package-lock.json # sampleManagement/package.json Merge branch 'develop' into fb_filePathIssues # Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
# Conflicts: # biologics/package-lock.json # biologics/package.json # inventory/package-lock.json # inventory/package.json # sampleManagement/package-lock.json # sampleManagement/package.json
This was referenced Jul 25, 2025
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
# Conflicts: # biologics/package-lock.json # biologics/package.json # inventory/package-lock.json # inventory/package.json # sampleManagement/package-lock.json # sampleManagement/package.json # sampleManagement/test/src/org/labkey/test/tests/samplemanagement/folders/SMProSamplesCrossFolderCRUDTest.java
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md Merge branch 'develop' into fb_filePathIssues # Conflicts: # biologics/package-lock.json # biologics/package.json # biologics/test/src/org/labkey/test/tests/biologics/assay/BiologicsAssayFilesTest.java # inventory/package-lock.json # inventory/package.json # sampleManagement/package-lock.json # sampleManagement/package.json # sampleManagement/test/src/org/labkey/test/tests/samplemanagement/samples/SMSampleUpdateTest.java
labkey-susanh
approved these changes
Aug 4, 2025
Contributor
labkey-susanh
left a comment
labkey-susanh
left a comment
There was a problem hiding this comment.
I have not done any testing of these changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
There are scenarios that the file is invalid but the triangle warning icon is not displayed. One scenario is when the file does exist on the file system, but the user lack permission to it or if it's of invalid access context from current folder. In those scenarios, we should show triangle warning icon.
Related Pull Requests
Changes