Skip to content

GitHub #788: Sample default field for LKSM assay results shouldn't show invalid type detail message #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cnathe merged 4 commits into from
Aug 6, 2025
Merged

GitHub #788: Sample default field for LKSM assay results shouldn't show invalid type detail message #1839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4aa7c5d
GitHub Issue 788: LKSM Default sample lookup for assay design should …
cnathe Aug 5, 2025
dcb4e8f
6.58.1-assaySample53500.0
cnathe Aug 5, 2025
9773f35
Update release notes with version number and release date
cnathe Aug 6, 2025
da94504
6.58.2
cnathe Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/components/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@labkey/components",
"version": "6.58.1",
"version": "6.58.2",
"description": "Components, models, actions, and utility functions for LabKey applications and pages",
"sideEffects": false,
"files": [
Expand Down
4 changes: 4 additions & 0 deletions packages/components/releaseNotes/components.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# @labkey/components
Components, models, actions, and utility functions for LabKey applications and pages

### version 6.58.2
*Released*: 6 August 2025
- GitHub Issue 788: LKSM Default sample lookup for assay design should default to lookupIsValid

### version 6.58.1
*Released*: 5 August 2025
- File handling - File path related issue bundle
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/internal/components/domainproperties/models.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,6 +883,7 @@ export interface IDomainField {
lockExistingField?: boolean;
lockType: string;
lookupContainer?: string;
lookupIsValid?: boolean;
lookupQuery?: string;
lookupQueryValue: string;
lookupSchema?: string;
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/internal/components/samples/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ export const DEFAULT_SAMPLE_FIELD_CONFIG = {
lookupQuery: 'Materials',
lookupType: { ...SAMPLE_TYPE },
lookupValidator: LOOKUP_VALIDATOR,
lookupIsValid: true,
propertyValidators: List([LOOKUP_VALIDATOR]),
name: 'SampleID',
label: 'Sample ID',
Expand Down