Issue 52878: Attachment thumbnails from ancestor columns not rendered in Sample Type grid#1863
Merged
Issue 52878: Attachment thumbnails from ancestor columns not rendered in Sample Type grid#1863
Conversation
… in Sample Type grid
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
# Conflicts: # biologics/package-lock.json # biologics/package.json # inventory/package-lock.json # inventory/package.json # sampleManagement/package-lock.json # sampleManagement/package.json Merge branch 'develop' into fb_issue52878 # Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
cnathe
requested changes
Oct 10, 2025
| } | ||
| } | ||
|
|
||
| if (!style && (col?.type?.toLowerCase() === 'file' || col?.inputType?.toLowerCase() === 'file')) |
Contributor
There was a problem hiding this comment.
seems odd to have this !style check here. so if the column has conditional formatting we won't use the FileColumnRenderer?
Seems like this check should be above the else here as a separate else if case.
Contributor
There was a problem hiding this comment.
Also, the QueryColumn has a isFileInput helper, can that be used here? or extended to support this case / check?
Contributor
Author
There was a problem hiding this comment.
This has to do with user avatar column on user's column. I guess it's ok for us to user file renderer there as well.
Contributor
Author
There was a problem hiding this comment.
Change made so q/core/SiteUsers/1004 also use File renderer for consistency, instead of link.
| if ( | ||
| List.isList(data) && | ||
| data.size === 1 && | ||
| (col?.type?.toLowerCase() === 'file' || col?.inputType?.toLowerCase() === 'file') |
Contributor
There was a problem hiding this comment.
same comment here about using the QueryColumn helper for isFileInput
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md Merge branch 'develop' into fb_issue52878 # Conflicts: # package-lock.json # package.json Merge branch 'develop' into fb_issue52878 # Conflicts: # biologics/package-lock.json # biologics/package.json # inventory/package-lock.json # inventory/package.json # sampleManagement/package-lock.json # sampleManagement/package.json # sampleManagement/test/src/org/labkey/test/tests/samplemanagement/SMBaseTest.java
# Conflicts: # biologics/package-lock.json # biologics/package.json # inventory/package-lock.json # inventory/package.json # sampleManagement/package-lock.json # sampleManagement/package.json
cnathe
approved these changes
Oct 10, 2025
Co-authored-by: Cory Nathe <cnathe@labkey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Related Pull Requests
Changes
AncestorRendererandMultiValueRendererto handle file/attachment columnsDefaultRendererto useFileColumnRenderer