Skip to content

Issue 53567: Improve "Alias" column performance #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-nicka merged 8 commits into from
Nov 7, 2025
Merged

Issue 53567: Improve "Alias" column performance #1875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4bfc065
Issue 53567: simplify alias
labkey-nicka Oct 15, 2025
d66b3a5
AliasInput: refer to "value" instead of "displayValue"
labkey-nicka Oct 24, 2025
a573ea6
v6.70.2-fb-alias-perf-53567.0
labkey-nicka Nov 6, 2025
695aa2d
Prepare release notes
labkey-nicka Nov 7, 2025
aa8f686
@labkey/eslint-config: use flat configuration for eslint-plugin-react
labkey-nicka Nov 7, 2025
3071749
@labkey/eslint-config@1.1.1
labkey-nicka Nov 7, 2025
494b5a2
Bump @labkey/eslint-config
labkey-nicka Nov 7, 2025
bb5d9fe
v6.70.2
labkey-nicka Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/components/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@labkey/components",
"version": "6.70.1",
"version": "6.70.2",
"description": "Components, models, actions, and utility functions for LabKey applications and pages",
"sideEffects": false,
"files": [
Expand Down Expand Up @@ -76,7 +76,7 @@
},
"devDependencies": {
"@labkey/build": "8.7.0",
"@labkey/eslint-config": "1.1.0",
"@labkey/eslint-config": "1.1.1",
"@types/history": "4.7.11",
"@types/jest": "30.0.0",
"@types/node": "24.10.0",
Expand Down
5 changes: 5 additions & 0 deletions packages/components/releaseNotes/components.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
# @labkey/components
Components, models, actions, and utility functions for LabKey applications and pages

### version 6.70.2
*Released*: 7 November 2025
- Issue 53567: Improve "Alias" column performance
- Update "Alias" column usages to refer to "value" instead of "displayValue" on select rows responses.

### version 6.70.1
*Released*: 6 November 2025
- use export-tools to remove unused package exports
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/internal/components/forms/input/AliasInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const AliasSelectInput: FC<Props> = memo(props => {
?.map(a => {
if (!a) return a;
if (typeof a === 'string') return a;
if (typeof a === 'object') return a.displayValue;
if (typeof a === 'object') return a.value;
return undefined;
})
.filter(a => !!a);
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/internal/renderers/AliasRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export class AliasRenderer extends React.Component<Props, State> {
if (data?.size > 0) {
const truncationLength = view === 'detail' ? DETAIL_ALIAS_WORD_LENGTH : GRID_ALIAS_WORD_LENGTH;
const extraCount = data.size - truncationLength;
const aliases = data.map(alias => alias.get('displayValue'));
const aliases = data.map(alias => alias.get('value'));

return (
<div className="alias-renderer" title={aliases.join(', ')}>
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default defineConfig([
typeScriptESLint.configs.recommended,
typeScriptESLint.configs.stylistic,
pluginReact.configs.flat.recommended,
pluginReactHooks.configs['recommended-latest'],
pluginReactHooks.configs.flat['recommended-latest'],
perfectionist.configs['recommended-natural'],
prettierRecommended,
{
Expand Down
4 changes: 2 additions & 2 deletions packages/eslint-config/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/eslint-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@labkey/eslint-config",
"version": "1.1.0",
"version": "1.1.1",
"description": "shareable eslint config for typescript",
"main": "eslint.config.mjs",
"files": [
Expand Down