Skip to content

Rename SaveRowsResponse to RowsResponse #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-nicka merged 1 commit into from
Jul 18, 2025
Merged

Rename SaveRowsResponse to RowsResponse #1398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions HormoneAssay/test/src/org/labkey/test/tests/external/labModules/HormoneAssayTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
import org.labkey.remoteapi.Connection;
import org.labkey.remoteapi.query.Filter;
import org.labkey.remoteapi.query.InsertRowsCommand;
import org.labkey.remoteapi.query.SaveRowsResponse;
import org.labkey.remoteapi.query.RowsResponse;
import org.labkey.remoteapi.query.SelectRowsCommand;
import org.labkey.remoteapi.query.SelectRowsResponse;
import org.labkey.test.Locator;
Expand Down Expand Up @@ -631,7 +631,7 @@ private void ensureTestRecords() throws CommandException, IOException
row.put("code", tests.get(test)[0]);
row.put("units", tests.get(test)[1]);
insertCmd.addRow(row);
SaveRowsResponse saveResp = insertCmd.execute(cn, getProjectName());
RowsResponse saveResp = insertCmd.execute(cn, getProjectName());
assertEquals("Incorrect row count", 1, saveResp.getRowsAffected().intValue());
}
}
Expand Down
8 changes: 4 additions & 4 deletions onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/AbstractGenericONPRC_EHRTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import org.labkey.remoteapi.SimplePostCommand;
import org.labkey.remoteapi.query.Filter;
import org.labkey.remoteapi.query.InsertRowsCommand;
import org.labkey.remoteapi.query.SaveRowsResponse;
import org.labkey.remoteapi.query.RowsResponse;
import org.labkey.remoteapi.query.SelectRowsCommand;
import org.labkey.remoteapi.query.SelectRowsResponse;
import org.labkey.test.Locator;
Expand Down Expand Up @@ -400,7 +400,7 @@ protected String ensureFlagExists(final String category, final String name, fina
}
});

SaveRowsResponse saveRowsResponse = insertRowsCommand.execute(getApiHelper().getConnection(), getContainerPath());
RowsResponse saveRowsResponse = insertRowsCommand.execute(getApiHelper().getConnection(), getContainerPath());
objectid = (String)saveRowsResponse.getRows().get(0).get("objectid");
}

Expand Down Expand Up @@ -450,7 +450,7 @@ protected Integer getOrCreateGroup(final String name) throws Exception
}
});

SaveRowsResponse saveRowsResponse = insertRowsCommand.execute(getApiHelper().getConnection(), getContainerPath());
RowsResponse saveRowsResponse = insertRowsCommand.execute(getApiHelper().getConnection(), getContainerPath());
groupId = (Integer)saveRowsResponse.getRows().get(0).get("rowid");
}

Expand Down Expand Up @@ -500,7 +500,7 @@ protected String getOrCreateSpfFlag(final String name) throws Exception
}
});

SaveRowsResponse saveRowsResponse = insertRowsCommand.execute(getApiHelper().getConnection(), getContainerPath());
RowsResponse saveRowsResponse = insertRowsCommand.execute(getApiHelper().getConnection(), getContainerPath());
objectid = (String)saveRowsResponse.getRows().get(0).get("objectid");
}

Expand Down
6 changes: 3 additions & 3 deletions onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/ONPRC_EHRTest2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
import org.labkey.remoteapi.query.ExecuteSqlCommand;
import org.labkey.remoteapi.query.Filter;
import org.labkey.remoteapi.query.InsertRowsCommand;
import org.labkey.remoteapi.query.SaveRowsResponse;
import org.labkey.remoteapi.query.RowsResponse;
import org.labkey.remoteapi.query.SelectRowsCommand;
import org.labkey.remoteapi.query.SelectRowsResponse;
import org.labkey.test.BaseWebDriverTest;
Expand Down Expand Up @@ -250,7 +250,7 @@ public void testBirthStatusApi() throws Exception
insertRowsCommand1.addRow(getApiHelper().createHashMap(birthFields, new Object[]{offspringId7, birthDate, "Live Birth", null, null, "f", room1, cage1, damId1, null, weight, birthDate, "In Progress"}));
insertRowsCommand1.addRow(getApiHelper().createHashMap(birthFields, new Object[]{offspringId8, birthDate, "Live Birth", null, null, "f", room1, cage1, damId1, null, weight, birthDate, "Completed"}));
insertRowsCommand1.setTimeout(0);
SaveRowsResponse insertRowsResp = insertRowsCommand1.execute(getApiHelper().getConnection(), getContainerPath());
RowsResponse insertRowsResp = insertRowsCommand1.execute(getApiHelper().getConnection(), getContainerPath());

final Map<String, String> lsidMap = new HashMap<>();
for (Map<String, Object> row : insertRowsResp.getRows())
Expand Down Expand Up @@ -757,7 +757,7 @@ public void testBirthInheritFromDam() throws Exception
String U24_PROJECT = "0492-03";
InsertRowsCommand projectCommand = new InsertRowsCommand("ehr", "project");
projectCommand.addRow(Maps.of("project", null, "name", U24_PROJECT, "protocol", DUMMY_PROTOCOL));
SaveRowsResponse saveRowsResponse = projectCommand.execute(getApiHelper().getConnection(), getContainerPath());
RowsResponse saveRowsResponse = projectCommand.execute(getApiHelper().getConnection(), getContainerPath());
Integer projectId = (Integer)saveRowsResponse.getRows().get(0).get("project");

// Insert dam project assignment into assignment via API
Expand Down