Skip to content

Test component audit event row count and diff count checks for Sample and Source delete and move#6745

Merged
cnathe merged 5 commits intodevelopfrom
fb_auditDiffCheckDeleteMove
Jun 13, 2025
Merged

Test component audit event row count and diff count checks for Sample and Source delete and move#6745
cnathe merged 5 commits intodevelopfrom
fb_auditDiffCheckDeleteMove

Conversation

@cnathe
Copy link
Contributor

@cnathe cnathe commented Jun 10, 2025

Rationale

Expanding on recent AuditLogHelper checks for audit event row/diff counts on actions like sample/source bulk update and details update, this PR adds similar checks within the test components for deleting and moving samples and sources.

Related Pull Requests

Changes

  • ExperimentServiceImpl.java: Updated the moveDataClassObjects method to include a check ensuring that an audit event is only created if transaction.getAuditEvent() is null.
  • ExperimentServiceImpl.java: Modified the moveAssayRuns method to add the same safeguard, preventing duplicate audit event creation during assay run moves.
  • SampleTypeServiceImpl.java: Adjusted the moveSamples method to include the check for an existing audit event before creating a new one.

@cnathe cnathe removed the request for review from XingY June 11, 2025 14:51
@cnathe cnathe merged commit fbabf34 into develop Jun 13, 2025
22 of 24 checks passed
@cnathe cnathe deleted the fb_auditDiffCheckDeleteMove branch June 13, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants