Conversation
…the name contains uppercase or special characters
…aracters from an assay field name
This was referenced Jun 17, 2025
labkey-susanh
approved these changes
Jun 17, 2025
experiment/src/org/labkey/experiment/api/property/DomainPropertyImpl.java
Outdated
Show resolved
Hide resolved
| { | ||
| updateBooleanValue(_domain.getDomainKind().getStorageSchemaName() + "." + _domain.getStorageTableName(), | ||
| _pd.getStorageColumnName(), _pdOld.getFormat(), null); | ||
| _pd.getLegalSelectName(dialect), _pdOld.getFormat(), null); |
Contributor
There was a problem hiding this comment.
I like this conversion. It does remind me that the need for the implicit lowercasing logic in getLegalSelectNameFromStorageName() is unfortunate.
labkey-matthewb
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
#755: Assay field type conversion from Boolean to String fails if the name contains uppercase characters
#778: Unable to edit assay run when a run-level sample field's name is > 50 characters
#779: Unable to import assay when result-level Sample field has name > 50 characters
Related Pull Requests
Changes