Prevent unsupported MVFK XML overrides#6793
Merged
labkey-klum merged 4 commits intodevelopfrom Jun 26, 2025
Merged
Conversation
labkey-nicka
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
related issue : https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=51695
A user could previously get into a bad state by editing the table metadata and using a MVFK type that wasn't supported. If that occurred, a user wouldn't be able to fix the query because we were throwing during table FK construction. This PR adds validation to the save action to prevent construction of an invalid FK. This also downgrades the previous exception to a warning to allow corrections to existing metadata.
Related Pull Requests
LabKey/testAutomation#2514