Skip to content

Issue 53408: Encode field names in attachment download links #6827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-susanh merged 1 commit into from
Jul 10, 2025
Merged

Issue 53408: Encode field names in attachment download links #6827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions experiment/src/org/labkey/experiment/api/ExpDataClassDataTableImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ private void configureAttachmentURL(MutableColumnInfo col)
{
ActionURL url = new ActionURL(ExperimentController.DataClassAttachmentDownloadAction.class, getUserSchema().getContainer())
.addParameter("lsid", "${LSID}")
.addParameter("name", "${" + col.getName() + "}");
.addParameter("name", "${" + PageFlowUtil.encode(col.getName()) + "}");
if (FileLinkDisplayColumn.AS_ATTACHMENT_FORMAT.equalsIgnoreCase(col.getFormat()))
{
url.addParameter("inline", "false");
Expand Down Expand Up @@ -622,7 +622,7 @@ public void decorateColumn(MutableColumnInfo columnInfo, PropertyDescriptor pd)
columnInfo.setURL(StringExpressionFactory.createURL(
new ActionURL(ExperimentController.DataClassAttachmentDownloadAction.class, getContainer())
.addParameter("lsid", "${LSID}")
.addParameter("name", "${" + columnInfo.getFieldKey() + "}")));
.addParameter("name", "${" + PageFlowUtil.encode(columnInfo.getName()) + "}")));

}

Expand Down
3 changes: 2 additions & 1 deletion list/src/org/labkey/list/model/ListTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
import org.labkey.api.security.permissions.UpdatePermission;
import org.labkey.api.study.assay.FileLinkDisplayColumn;
import org.labkey.api.util.ContainerContext;
import org.labkey.api.util.PageFlowUtil;
import org.labkey.api.util.StringExpressionFactory;
import org.labkey.api.view.ActionURL;
import org.labkey.data.xml.TableType;
Expand Down Expand Up @@ -366,7 +367,7 @@ public void overlayMetadata(Collection<TableType> metadata, UserSchema schema, C

private void configureAttachmentURL(MutableColumnInfo col)
{
ActionURL url = ListController.getDownloadURL(_list, "${EntityId}", "${" + col.getName() + "}");
ActionURL url = ListController.getDownloadURL(_list, "${EntityId}", "${" + PageFlowUtil.encode(col.getName()) + "}");
if (FileLinkDisplayColumn.AS_ATTACHMENT_FORMAT.equalsIgnoreCase(col.getFormat()))
{
url.addParameter("inline", "false");
Expand Down