TestDataGenerator randomFieldName and randomDomainName usage of ValidateDomainAndFieldNamesAction#6859
Merged
TestDataGenerator randomFieldName and randomDomainName usage of ValidateDomainAndFieldNamesAction#6859
Conversation
…nd trip values through folder export/import
…nerator.randomFieldName
…e checks in various domainKinds
…alidate domain names based on the domain kind
…et data import via textarea
labkey-susanh
approved these changes
Jul 22, 2025
experiment/src/org/labkey/experiment/controllers/property/PropertyController.java
Outdated
Show resolved
Hide resolved
| */ | ||
| @Test | ||
| public void testIssue454644() throws Exception | ||
| public void testIssue45664() throws Exception |
Contributor
There was a problem hiding this comment.
I know it's not actually from this PR, but I don't love test names like this that are not mnemonic.
… and continue error check in ValidateDomainAndFieldNamesAction
This was referenced Jul 24, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We've been slowly handling various cases on the test code side to account for randomly generated domain and field names that end up being invalid (because of invalid character sequences, length, etc.). This PR changes that approach so that we instead call a server API (ValidateDomainAndFieldNamesAction) to do those checks on the generated name and regenerate the name if it is invalid.
Related Pull Requests
Changes