Revert support for case insensitive sample/data names#6868
Merged
Conversation
# Conflicts: # api/src/org/labkey/api/query/AbstractQueryUpdateService.java # experiment/src/client/test/integration/DataClassCrud.ispec.ts
labkey-susanh
approved these changes
Jul 23, 2025
| }, { ...topFolderOptions, ...editorUserOptions }).expect((result) => { | ||
| errorResp = JSON.parse(result.text); | ||
| expect(errorResp.exception.indexOf('already exists') > -1).toBeTruthy(); | ||
| expect(errorResp.exception.indexOf('duplicate key') > -1).toBeTruthy(); |
Contributor
There was a problem hiding this comment.
Looks like a change to BOGUS_KEY_UPDATE_ERROR (above) did not get reverted.
Contributor
Author
There was a problem hiding this comment.
Yep, fixed. Thanks for catching it.
| dialect.appendInClauseSql(sql, sampleIds); | ||
|
|
||
| Map<Integer, Pair<Integer, String>> sampleAliquotCounts = new TreeMap<>(); // Order sample by rowId to reduce probability of deadlock with search indexer | ||
| Map<Integer, Pair<Integer, String>> sampleAliquotCounts = new HashMap<>(); |
Contributor
There was a problem hiding this comment.
This change seems like it was rather unrelated to the issue fix. I'm ok with reverting this too, but just wanted to check that it is intentional
Contributor
Author
There was a problem hiding this comment.
Good point. Changes added back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
There was a set of PRs that got merged to disallow insert/update of case insensitive sample/data names. However, this has resulted in performance degradation of sample imports. Furthermore, this is more of a half way solution that treats name as case insensitive at insert/rename time, but requires exact match at update time. For those reasons, we have decided to revert the previous PRs for now. An alternative database level collation approach will be explored at a future time.
Minor: there was a client side change to show exact case as user provided instead of lower-case when generating duplicate error on the editable grid. This improvement is not included in the revert.
Related Pull Requests
Original Pull Requests that added support for case insensitive names
Pull Requests attempts to improve import performance (never merged)
Changes