Issue 53498: Sample Manager: Attachment field is lost after export/import round trip #6894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Manual testing notes
|
labkey-susanh
approved these changes
Jul 31, 2025
| classesToTest.add(0, knownColumnClass); | ||
|
|
||
| // Issue 49830: if we know the column class is File based on the columnInfoMap, use it instead of trying to infer the class based on the data | ||
| if (setFileColDescriptor(colDescs[f], knownColumn)) |
Contributor
There was a problem hiding this comment.
Seems like this could come before the setting of knownColumnClass.
| } | ||
|
|
||
| // use File converter for known file fields even if inferTypes = false. If inferTypes, this is already done. | ||
| if (!getInferTypes()) |
Contributor
There was a problem hiding this comment.
Seems like you could leave off the if statement here for a cleaner read since setting again won't hurt, but this is slightly more efficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This PR skip File converter for Attachment columns for import and allow string values to be rejected/validated during AttachmentDataIterator processing. The only time AttachmentDataIterator would accept a string attachment currently is during list archive import, where the attachment parents are set. There will be a follow up PR that addresses QUS of attachment.
Related Pull Requests
Changes