Assay: update instead of overwrite domain fields#6905
Merged
labkey-nicka merged 4 commits intodevelopfrom Aug 12, 2025
Merged
Conversation
cnathe
approved these changes
Aug 6, 2025
labkey-nicka
force-pushed
the
fb_assay_domain_field
branch
from
fee8d73 to
4dad4dd
Compare
cnathe
approved these changes
Aug 7, 2025
labkey-nicka
force-pushed
the
fb_assay_domain_field
branch
from
4dad4dd to
c5de31f
Compare
labkey-nicka
force-pushed
the
fb_assay_domain_field
branch
from
c5de31f to
d08205f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
While testing changes in #6883 related to https://github.com/LabKey/internal-issues/issues/657 I discovered that it was not round-tripping the
lookupIsValidproperty on the result domain field as I would have expected. Come to find out thatAssayDomainServiceImpl.getDomain()is unintentionally overwriting property descriptor processing done byDomainUtil.getDomainDescriptor(). This updates assay domain processing to perform a deep copy of the fields procured by the domain and then apply assay-specific overrides on those fields.Related Pull Requests
Changes
AssayDomainServiceImpl.getDomain()to no longer overwrite fields