Skip to content

Conversation

@labkey-susanh
Copy link
Contributor

@labkey-susanh labkey-susanh commented Sep 16, 2025

Rationale

If the "startup in progress" page refreshes while the system is in the process of adding audit logs for the upgrade script for amounts and units, it will stash the audit log count too early and show a warning before all logs have been created. This PR doesn't generate the warning until module startup is complete and thus all audit logs have been written.

Related Pull Requests

Changes

  • Add check for module startup complete

Tasks 📍

Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a reminder to delete the warning code when we remove Java upgrade code. Maybe a comment on ExperimentUpgradeCode.updateAmountsAndUnits()? @labkey-adam might have ideas on places we'd see it

@labkey-adam
Copy link
Contributor

We should add a reminder to delete the warning code when we remove Java upgrade code. Maybe a comment on ExperimentUpgradeCode.updateAmountsAndUnits()? @labkey-adam might have ideas on places we'd see it

Yes, comment on the upgrade method would be best.

@labkey-susanh
Copy link
Contributor Author

We should add a reminder to delete the warning code when we remove Java upgrade code. Maybe a comment on ExperimentUpgradeCode.updateAmountsAndUnits()? @labkey-adam might have ideas on places we'd see it

Yes, comment on the upgrade method would be best.

Done.

@labkey-susanh labkey-susanh merged commit 4269b0f into develop Sep 17, 2025
11 checks passed
@labkey-susanh labkey-susanh deleted the fb_noEarlyWarnings branch September 17, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants