Issue 53168: An aliquot can be updated to be its own parent’s parent#7091
Merged
Issue 53168: An aliquot can be updated to be its own parent’s parent#7091
Conversation
labkey-susanh
requested changes
Oct 3, 2025
| } | ||
| catch (Exception e) | ||
| { | ||
| assertThat(e.getMessage(), containsString("'C1' is aliquoted from sample 'P2-1'. Circular relationships are not allowed.")); |
Contributor
There was a problem hiding this comment.
The message seems wrong here. C1 is derived not aliquoted, isn't it?
labkey-susanh
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We don't allow a sample/data to be its own parent, but we allow its descendent to be added as ancestors, resulting in circular lineage. This PR add check to see if a new parent is a existing child. This PR doesn't check for >1 generation descendants against parents.
Related Pull Requests
Changes
Tasks 📍