Skip to content

Return Set<Class<?>> from Module "get test" methods#7098

Merged
labkey-adam merged 3 commits intodevelopfrom
fb_unit_test_sets
Oct 3, 2025
Merged

Return Set<Class<?>> from Module "get test" methods#7098
labkey-adam merged 3 commits intodevelopfrom
fb_unit_test_sets

Conversation

@labkey-adam
Copy link
Contributor

Rationale

Eliminate IntelliJ warnings caused by Module methods getUnitTests() and getIntegrationTests() returning raw Set<Class>; they now return Set<Class<?>>.

Also, eliminate use of the deprecated AbstractAuditTypeProvider() constructor and overrides of getDomainKind() in its subclasses; we now always call the constructor that passes in a DomainKind.

@labkey-adam labkey-adam requested a review from a team October 2, 2025 21:08
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we don't need manual testing. We can verify that the BVT run has the same number of tests before and after this change, meaning the unit/integration tests are being found and executed.

@labkey-adam labkey-adam self-assigned this Oct 3, 2025
@labkey-adam
Copy link
Contributor Author

Seems like we don't need manual testing. We can verify that the BVT run has the same number of tests before and after this change, meaning the unit/integration tests are being found and executed.

BVT runs on this branch and on develop yesterday both report 553 tests passed:

@labkey-adam labkey-adam merged commit 970e478 into develop Oct 3, 2025
11 checks passed
@labkey-adam labkey-adam deleted the fb_unit_test_sets branch October 3, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants