Return Set<Class<?>> from Module "get test" methods#7098
Merged
labkey-adam merged 3 commits intodevelopfrom Oct 3, 2025
Merged
Return Set<Class<?>> from Module "get test" methods#7098labkey-adam merged 3 commits intodevelopfrom
labkey-adam merged 3 commits intodevelopfrom
Conversation
labkey-jeckels
approved these changes
Oct 2, 2025
Contributor
labkey-jeckels
left a comment
There was a problem hiding this comment.
Seems like we don't need manual testing. We can verify that the BVT run has the same number of tests before and after this change, meaning the unit/integration tests are being found and executed.
Contributor
Author
BVT runs on this branch and on develop yesterday both report 553 tests passed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Eliminate IntelliJ warnings caused by
ModulemethodsgetUnitTests()andgetIntegrationTests()returning rawSet<Class>; they now returnSet<Class<?>>.Also, eliminate use of the deprecated
AbstractAuditTypeProvider()constructor and overrides ofgetDomainKind()in its subclasses; we now always call the constructor that passes in aDomainKind.