Skip to content

ListItemDetailsAction: improve parameter resolution #7103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-nicka merged 1 commit into from
Oct 6, 2025
Merged

ListItemDetailsAction: improve parameter resolution #7103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions list/src/org/labkey/list/controllers/ListController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,8 +894,8 @@ public ModelAndView getView(ListItemDetailsForm form, BindException errors)

if (_list == null)
{
int listId = form.getListId();
if (listId > 0)
Integer listId = form.getListId();
if (listId != null && listId > 0)
_list = ListService.get().getList(getContainer(), listId);
}

Expand All @@ -906,7 +906,10 @@ public ModelAndView getView(ListItemDetailsForm form, BindException errors)
String oldRecord = null;
String newRecord = null;

int eventRowId = form.getRowId();
Integer eventRowId = form.getRowId();
if (eventRowId == null || eventRowId <= 0)
return HtmlView.of("Unable to resolve event details. An event \"rowId\" must be specified.");

ListAuditProvider.ListAuditEvent event = AuditLogService.get().getAuditEvent(getUser(), ListManager.LIST_AUDIT_EVENT, eventRowId);

if (event != null)
Expand Down