Convert NowTimestamp to Timestamp#7114
Merged
labkey-nicka merged 2 commits intodevelopfrom Oct 12, 2025
Merged
Conversation
labkey-jeckels
approved these changes
Oct 10, 2025
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
Test is passing in this FB. I didn't manually test since it seems like the test is sufficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Serialization of
NowTimestampis not resolved in the same way asjava.sql.Timestampeven though it extendsjava.sql.Timestamp. Rather than looking forNowTimestampeverywhere and hooking up custom converters I've elected to just convert back allNowTimestamptoTimestampimmediately when setting the property values inTable.Related Pull Requests
Changes
NowTimestampinstances and convert toTimestampbefore setting property.