Skip to content

Permission validation for related issues #7116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-klum merged 1 commit into from
Oct 14, 2025
Merged

Permission validation for related issues #7116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion issues/src/org/labkey/issue/IssueServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,8 @@ public Issue saveIssue(ViewContext context, Issue issue, Issue.action action, Li
for (int curIssueId : prevIssues)
{
IssueObject relatedIssue = ChangeSummary.relatedIssueCommentHandler(issueObject.getIssueId(), curIssueId, user, true);
IssueManager.saveIssue(getRelatedIssueUser(container, user, relatedIssue), container, relatedIssue);
if (null != relatedIssue)
IssueManager.saveIssue(getRelatedIssueUser(container, user, relatedIssue), container, relatedIssue);
}
}

Expand Down
9 changes: 7 additions & 2 deletions issues/src/org/labkey/issue/actions/IssueValidation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,13 +231,18 @@ public static void relatedIssueHandler(IssueObject issue, User user, Errors erro
}
}

// Issue 40178: Related Issues need to be in synch when related issues are deleted
// Issue 40178: Related Issues need to be in sync when related issues are deleted
for (Integer originalRelatedId : originalRelatedIssues)
{
if (!newRelatedIssues.contains(originalRelatedId))
{
IssueObject related = IssueManager.getIssue(null, user, originalRelatedId);
if (null != related)
if (related == null || !related.lookupContainer().hasPermission(user, ReadPermission.class))
{
errors.reject(SpringActionController.ERROR_MSG, "User does not have Read Permission for related issue '" + originalRelatedId + "'");
return;
}
else
{
related = ChangeSummary.relatedIssueCommentHandler(originalIssue.getIssueId(), related.getIssueId(), user, true );
IssueManager.saveIssue(user, related.lookupContainer(), related);
Expand Down