Improve plate assay import performance#7124
Merged
labkey-alan merged 2 commits intodevelopfrom Oct 16, 2025
Merged
Conversation
labkey-nicka
approved these changes
Oct 15, 2025
assay/src/org/labkey/assay/plate/AssayPlateMetadataServiceImpl.java
Outdated
Show resolved
Hide resolved
labkey-alan
force-pushed
the
fb_improve_plate_assay_import_perf
branch
from
4cb772f to
b3867b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR slightly optimizes the way we query for well samples, and preloads all exp materials for a plate into the
materialCacheduring import, which improves performance.Benchmarks from my machine show that on develop import time is approximately 58% slower than 25.10. With the changes in this PR import time is approximately 24% slower.
Assay import time is expected to be slower by some amount, because when marking well samples as Material Inputs we are inserting at least 3x the amount of rows into the database, and we are also making additional queries to the Well table during import (in order to determine what samples to mark as inputs).
Related Pull Requests
Changes
materialCache