Skip to content

ObjectFactory fails to map reserved field names #7132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XingY merged 2 commits into from
Oct 20, 2025
Merged

ObjectFactory fails to map reserved field names #7132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10a9394
ObjectFactory fails to map reserved field names
XingY Oct 17, 2025
a08c524
allow user domain to use reserved db fields
XingY Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions api/src/org/labkey/api/data/BeanObjectFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,14 @@ public ArrayList<K> handleArrayList(ResultSet rs) throws SQLException
String prop = propMap.get(label); //Map to correct casing...
if (null != prop)
properties[i] = prop;
else if (label.endsWith("_"))
{
// Try stripping trailing underscore (added by some databases for reserved words)
// For example "File" is a reserved word in SQL Server, but it's used by FileSystemAuditDomainKind/FileSystemAuditEvent
prop = propMap.get(label.substring(0, label.length() - 1));
if (null != prop)
properties[i] = prop;
}
}

ArrayList<K> list = new ArrayList<>();
Expand Down
4 changes: 4 additions & 0 deletions experiment/src/org/labkey/experiment/api/property/StorageProvisionerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,10 @@ public void addProperties(Domain domain, Collection<DomainProperty> properties,
log.warn("StorageProvisioner ignored property with name of built-in column: " + prop.getPropertyURI());
continue;
}

if (CoreSchema.getInstance().getSqlDialect().isReserved(prop.getName()))
log.warn("Property name '" + prop.getName() + "' is a reserved word in the current SQL dialect.");

PropertyStorageSpec spec = kind.getPropertySpec(prop.getPropertyDescriptor(), domain);
if (null != spec)
{
Expand Down