Skip to content

Export SVG plots to PNG at higher resolution#7178

Merged
labkey-adam merged 5 commits intorelease25.11-SNAPSHOTfrom
25.11_fb_high_resolution_pngs
Nov 18, 2025
Merged

Export SVG plots to PNG at higher resolution#7178
labkey-adam merged 5 commits intorelease25.11-SNAPSHOTfrom
25.11_fb_high_resolution_pngs

Conversation

@labkey-adam
Copy link
Contributor

@labkey-adam labkey-adam commented Nov 5, 2025

Rationale

In short, export SVG -> PNG at a minimum height of 2,000 pixels, regardless of the browser-submitted height.

https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=53390

Also, extract duplicated code from two export actions into a base class

Tasks 📍

@labkey-adam labkey-adam self-assigned this Nov 5, 2025
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

ERROR: A pull request from 25.11_fb_high_resolution_pngs is expected to target release25.11-SNAPSHOT, not develop

@labkey-jeckels labkey-jeckels changed the base branch from develop to release25.11-SNAPSHOT November 5, 2025 18:03
@labkey-tchad
Copy link
Member

Working as specified. That being said, 2000px is quite large and I might assume something is going wrong if I didn't know better.
Maybe we could update the tooltip on the export button to explicitly say "Export to Hi-res PNG"?

@labkey-adam
Copy link
Contributor Author

Working as specified. That being said, 2000px is quite large and I might assume something is going wrong if I didn't know better. Maybe we could update the tooltip on the export button to explicitly say "Export to Hi-res PNG"?

I'm okay with that, but I'm inclined to open a separate issue for this to get some triage eyes on the change and also recognizing that this expands beyond generic & time charts to QC plots, svgChart.js, etc.

@labkey-adam labkey-adam merged commit 294d478 into release25.11-SNAPSHOT Nov 18, 2025
18 of 21 checks passed
@labkey-adam labkey-adam deleted the 25.11_fb_high_resolution_pngs branch November 18, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants