Skip to content

Conversation

@labkey-tchad
Copy link
Member

Rationale

Experiment endpoints tests have been failing intermittently because they can generate invalid domain names.

Error: expect(received).toHaveProperty(path)
Expected path: "domainId"
Received path: []
Received value: {"exception": "Invalid DataClass name 'aA -_)'. DataClass name may not contain space followed by dash.", "exceptionClass": "java.lang.IllegalArgumentException", "stackTrace": [{"classLoaderName": null, "className": "org.labkey.api.exp.property.DomainUtil", "fileName": "DomainUtil.java", "lineNumber": 734, "methodName": "createDomain", "moduleName": null, "moduleVersion": null, "nativeMethod": false}, {"classLoaderName": null, "className": "org.labkey.experiment.controllers.property.PropertyController$CreateDomainAction", "fileName": "PropertyController.java", "lineNumber": 328, "methodName": "execute", "moduleName": null, "moduleVersion": null, "nativeMethod": false}, {"classLoaderName": null, "className": "org.labkey.experiment.controllers.property.PropertyController$CreateDomainAction", "fileName": "PropertyController.java", "lineNumber": 247, "methodName": "execute", "moduleName": null, "moduleVersion": null, "nativeMethod": false}, {"classLoaderName": null, "className": "org.labkey.api.action.BaseApiAction", "fileName": "BaseApiAction.java", "lineNumber": 237, "methodName": "handlePost", "moduleName": null, "moduleVersion": null, "nativeMethod": false}, {"classLoaderName": null, "className": "org.labkey.api.action.BaseApiAction", "fileName": "BaseApiAction.java", "lineNumber": 127, "methodName": "handleRequest", "moduleName": null, "moduleVersion": null, "nativeMethod": false}, {"classLoaderName": null, "className": "org.labkey.api.action.BaseViewAction", "fileName": "BaseViewAction.java", "lineNumber": 243, "methodName": "handleRequest", "moduleName": null, "moduleVersion": null, "nativeMethod": false}, {"classLoaderName": null, "className": "org.labkey.api.action.SpringActionController", "fileName": "SpringActionController.java", "lineNumber": 534, "methodName": "handleRequest", "moduleName": null, "moduleVersion": null, "nativeMethod": false}, {"classLoaderName": null, "className": "org.labkey.api.module.DefaultModule", "fileName": "DefaultModule.java", "lineNumber": 1130, "methodName": "dispatch", "moduleName": null, "moduleVersion": null, "nativeMethod": false}, {"classLoaderName": null, "className": "org.labkey.api.view.ViewServlet", "fileName": "ViewServlet.java", "lineNumber": 202, "methodName": "_service", "moduleName": null, "moduleVersion": null, "nativeMethod": false}, {"classLoaderName": null, "className": "org.labkey.api.view.ViewServlet", "fileName": "ViewServlet.java", "lineNumber": 126, "methodName": "service", "moduleName": null, "moduleVersion": null, "nativeMethod": false}, …], "success": false}
    at verifyDomainCreateSuccess (D:\teamcity\work\a7b1f3583054d6ed\server\modules\platform\experiment\src\client\test\integration\utils.ts:503:44)
    at checkDomainName (D:\teamcity\work\a7b1f3583054d6ed\server\modules\platform\experiment\src\client\test\integration\utils.ts:552:43)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at Object.<anonymous> (D:\teamcity\work\a7b1f3583054d6ed\server\modules\platform\experiment\src\client\test\integration\DataClassCrud.ispec.ts:78:9)

Related Pull Requests

Changes

  • Ensure legal random domain names in experiment integration tests

@labkey-tchad labkey-tchad requested a review from XingY November 10, 2025 19:12
@labkey-tchad labkey-tchad merged commit 7ea2d40 into release25.11-SNAPSHOT Nov 11, 2025
12 of 13 checks passed
@labkey-tchad labkey-tchad deleted the 25.11_fb_legalRandomDomainName branch November 11, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants