Update report.descriptorXML to NVARCHAR #7205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
approved these changes
Nov 12, 2025
| @@ -0,0 +1 @@ | |||
| -- no op, changeset for version tracking only. core.Report.DescriptorXML TEXT type is already sufficient No newline at end of file | |||
Contributor
There was a problem hiding this comment.
FWIW, this script shouldn't cause any harm but shouldn't be necessary either.
Contributor
Author
There was a problem hiding this comment.
OK, I removed this file. BVT keeps failing with initializationError, not sure if it's related to this, but once removed, BVT is green again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
report.descriptorXML column is currently of TEXT type. This causes issue with storing unicode characters for sql server. See test failure:
SMProAssayCreateTest.testRenameAssay (MSSQL)
SampleFinder cannot find sample table if assay is renamed.
Related Pull Requests
Changes