Skip to content

Rudimentary integration with GitHub issues from exception reports#7216

Merged
labkey-jeckels merged 3 commits intorelease25.11-SNAPSHOTfrom
25.11_fb_mothershipGitHub
Nov 21, 2025
Merged

Rudimentary integration with GitHub issues from exception reports#7216
labkey-jeckels merged 3 commits intorelease25.11-SNAPSHOTfrom
25.11_fb_mothershipGitHub

Conversation

@labkey-jeckels
Copy link
Contributor

@labkey-jeckels labkey-jeckels commented Nov 18, 2025

Rationale

We've migrated to using GitHub for issue tracking. Thus, we want to make it easy to open GitHub issues from exception reports, and don't need to keep supporting creating LabKey issues from exceptions.

Changes

  • Separate columns for LabKey and GitHub issue numbers
  • Switch Create Issue button to target GitHub with our standard body and title templates
  • Remove tests that actually created issues

Tasks 📍

  • Manual Testing @labkey-klum
    • Successful schema upgrade
    • Mothership -> Configure Mothership
      • Set a path to a container with issues
      • Fill in a GitHub repo (internal-issues)
        • If you leave off the github issue, the create issue button is enabled but it navigates you to a 404 @labkey-jeckels
    • Go to the exception list
      • Should see an Issues column
    • Click on an exception
      • Click on Create Issue
        • Should take you to GitHub with the same title and body we used for LabKey issues
      • Fill in a GitHub issue number
      • Ensure link for Issues column in grid takes you to GitHub issue
    • Click on a different exception
      • Fill in a LabKey issue number
        • Seems fine to make one available, maybe other clients still use the LKS issue integration but I would expect that we never populate that field going forward. @labkey-jeckels
      • Ensure link for Issues column in grid takes you to the LabKey issue
  • Needs Automation
  • Verify Fix @labkey-robert

@labkey-jeckels
Copy link
Contributor Author

@labkey-klum labkey.org is the only distribution that includes the mothership module. I agree it's unlikely anyone will be filling in LK issue numbers in the future but didn't feel like killing the column or preventing the reference.

@labkey-jeckels
Copy link
Contributor Author

@labkey-klum I fixed the issue where we showed Create Issue without a repo configured (handle empty string instead of just null)

@labkey-jeckels labkey-jeckels merged commit 51877cd into release25.11-SNAPSHOT Nov 21, 2025
11 of 12 checks passed
@labkey-jeckels labkey-jeckels deleted the 25.11_fb_mothershipGitHub branch November 21, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants