Skip to content

Ignore IllegalStateException when request is already recycled#7232

Merged
labkey-jeckels merged 1 commit intodevelopfrom
fb_illegalStateExceptionRequest
Dec 2, 2025
Merged

Ignore IllegalStateException when request is already recycled#7232
labkey-jeckels merged 1 commit intodevelopfrom
fb_illegalStateExceptionRequest

Conversation

@labkey-jeckels
Copy link
Contributor

Rationale

There's a race condition between a request finishing and when we check to see if it's still pending and needs to yank its DB connections.

java.lang.IllegalStateException: The request object has been recycled and is no longer associated with this facade
    at jakarta.servlet.ServletRequestWrapper.getAttribute(ServletRequestWrapper.java:83)
    at org.labkey.api.data.TransactionFilter$1.lambda$moduleStartupComplete$0(TransactionFilter.java:120)
    at java.base/java.lang.Thread.run(Unknown Source)

Changes

  • Suppress the IllegalStateException

Tasks 📍

  • Manual Testing - N/A
  • Needs Automation - N/A

@labkey-jeckels labkey-jeckels requested a review from a team December 1, 2025 17:38
@labkey-jeckels labkey-jeckels self-assigned this Dec 1, 2025
@labkey-jeckels labkey-jeckels merged commit 2538c9f into develop Dec 2, 2025
11 checks passed
@labkey-jeckels labkey-jeckels deleted the fb_illegalStateExceptionRequest branch December 2, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants