Avoid error logging on bad SQL parameter values#7233
Merged
labkey-jeckels merged 1 commit intorelease25.11-SNAPSHOTfrom Dec 4, 2025
Merged
Avoid error logging on bad SQL parameter values#7233labkey-jeckels merged 1 commit intorelease25.11-SNAPSHOTfrom
labkey-jeckels merged 1 commit intorelease25.11-SNAPSHOTfrom
Conversation
Contributor
Author
|
@labkey-matthewb see what you think. I'm open to other approaches. |
labkey-matthewb
approved these changes
Dec 2, 2025
Contributor
labkey-matthewb
left a comment
labkey-matthewb
left a comment
There was a problem hiding this comment.
Seem generally fine. My only observation is that the name of the class SQLGenerationException() sounds more like a LabKey problem than a user/caller problem. Then again the specific class SQLParameterException make sense.
labkey-tchad
approved these changes
Dec 4, 2025
Member
labkey-tchad
left a comment
labkey-tchad
left a comment
There was a problem hiding this comment.
Manual testing complete: ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We don't want to spam the log or mothership with exceptions caused by bad SQL parameter values.
Changes
Tasks 📍