Skip to content

Issue 54076: Antivirus Support: Improve error messaging for ClamAV-flagged uploads with link to client guidance #7238

Merged
labkey-bpatel merged 7 commits intorelease25.11-SNAPSHOTfrom
25.11_fb_antivirus_error_msg
Dec 10, 2025
Merged

Issue 54076: Antivirus Support: Improve error messaging for ClamAV-flagged uploads with link to client guidance #7238
labkey-bpatel merged 7 commits intorelease25.11-SNAPSHOTfrom
25.11_fb_antivirus_error_msg

Conversation

@labkey-bpatel
Copy link
Contributor

@labkey-bpatel labkey-bpatel commented Dec 2, 2025 •
edited
Loading

Rationale

Issue 54076: Antivirus Support: Improve error messaging for ClamAV-flagged uploads with link to client guidance

Related Pull Requests

Changes

  • Update error message

labkey-adam
labkey-adam requested changes Dec 5, 2025
View reviewed changes
Copy link
Contributor

@labkey-adam labkey-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording change to match what's requested in the issue

labkey-adam
labkey-adam requested changes Dec 8, 2025
View reviewed changes
Copy link
Contributor

@labkey-adam labkey-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the extra message to a constant in API (I suggest AntiVirusService) so it can be used in both DavController and AntiVirusMultipartResolver, and we don't have to duplicate this message in the product? I know the test needs it's own copy, but good to share in the product. Sorry I didn't think of this before...

@labkey-bpatel
Copy link
Contributor Author

labkey-bpatel commented Dec 9, 2025

Can we move the extra message to a constant in API (I suggest AntiVirusService) so it can be used in both DavController and AntiVirusMultipartResolver, and we don't have to duplicate this message in the product? I know the test needs it's own copy, but good to share in the product. Sorry I didn't think of this before...

Done! Good call, thank you!

@labkey-bpatel labkey-bpatel merged commit 5dd0eed into release25.11-SNAPSHOT Dec 10, 2025
9 of 11 checks passed
@labkey-bpatel labkey-bpatel deleted the 25.11_fb_antivirus_error_msg branch December 10, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@labkey-adam labkey-adam labkey-adam approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@labkey-bpatel @labkey-adam